Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings preventing musl builds for c0.3.0 #1648

Closed
cpswan opened this issue Jan 13, 2025 · 2 comments
Closed

Compiler warnings preventing musl builds for c0.3.0 #1648

cpswan opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Jan 13, 2025

Describe the bug

warning: format string is not a string literal (potentially insecure) [-Wformat-security]

From the c0.3.0 build workflow where the musl builds fail with:

#9 31.84   112 |       fprintf(stdout, usage);
#9 31.84       |                       ^~~~~
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:112:23: note: treat the string as an argument to avoid this
#9 31.84   112 |       fprintf(stdout, usage);
#9 31.84       |                       ^
#9 31.84       |                       "%s", 
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:116:23: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
#9 31.84   116 |       fprintf(stderr, usage);
#9 31.84       |                       ^~~~~
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:116:23: note: treat the string as an argument to avoid this
#9 31.84   116 |       fprintf(stderr, usage);
#9 31.84       |                       ^
#9 31.84       |                       "%s", 
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:130:21: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
#9 31.84   130 |     fprintf(stderr, usage);
#9 31.84       |                     ^~~~~
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:130:21: note: treat the string as an argument to avoid this
#9 31.84   130 |     fprintf(stderr, usage);
#9 31.84       |                     ^
#9 31.84       |                     "%s", 
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:136:21: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
#9 31.84   136 |     fprintf(stderr, usage);
#9 31.84       |                     ^~~~~
#9 31.84 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atactivate_arg_parser.c:136:21: note: treat the string as an argument to avoid this
#9 31.84   136 |     fprintf(stderr, usage);
#9 31.84       |                     ^
#9 31.84       |                     "%s", 

Steps to reproduce

  1. First I bumped versions in chore: Bump version to 0.3.0 and update CHANGELOG #1647
  2. Then I created a pre-release for c0.3.0
  3. And then the musl builds failed with the warnings above

Expected behavior

Builds with no warnings

@cpswan cpswan added the bug Something isn't working label Jan 13, 2025
@XavierChanth
Copy link
Member

XavierChanth commented Jan 13, 2025

fprintf warnings fixed in atsign-foundation/at_c#496
PR fixing another compile warning: atsign-foundation/at_c#506

PR in NoPorts pinned to at_c#506 #1649

@cpswan
Copy link
Member Author

cpswan commented Jan 14, 2025

Fixed by #1649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants