-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The gist service doesn't run on Java 10 #4
Comments
Nods, I am pretty sure I had to back out to Java 1.8. With version 9+ it ran but rules wouldn't match, so the service could not authenticate. |
Hi Simon and Gordon, hope you are both well. Couldn't resist this ticket. I have an update to the code to get it to run on Java 11 basically a load of dependencies needed to be updated due to the way Java has changed since I originally wrote this which had a slight knock on effect on the code. The dependencies could possibly do with tweaking a bit more as they are still not up to the latest but are probably OK for the moment. I haven't got an RCloud environment with which to the changes so can't provide many guarantees that it is completely working, but it compiles, all the unit tests pass, it starts up and I've created a basic gist although admittedly no content. I've based the changes on the develop branch (again wasn't sure which branch you're really using). It's in my fork here: https://github.com/boxheed/rcloud-gist-services/tree/develop I can create a pull request if you want. |
Wow! Thanks @boxheed! Much appreciated. I have to let go of RCloud for a few days and catch up with everything else. Hope to review next week. It was our Public Cloud demo today so I have been cramming RCloud for about 10 days. Needs some updates but it is still a really neat platform. |
@gordonwoodhull No problem, give me a shout if anything doesn't make sense or you want the changes applied elsewhere. Happy to help out. |
The service fails with
In addition, it doesn't compile under Java 10 for two reasons:
gradlew
fails withgradle
build fails withIt seems possible to work around this issue by using
but it's unclear if/how that would affect older Java versions.
The text was updated successfully, but these errors were encountered: