feat: benchmark reorganization #8
Conversation
Creates the following directories to house the reorganized benchmark tests: - c-1: For existing CPU-based C tests. - c-gpu-1: For existing GPU-based C tests. - c-php-sourced: For new C tests based on the PHP source code.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Moves all existing CPU-based C test source files from the `c/` directory to the newly created `c-1/` directory. - Creates a `Makefile` in `c-1/` to build these tests, adapted from the original `Makefile`.
- Moves the `password_hash_gpu.cu` test from the `c/` directory to the `c-gpu-1/` directory. - Creates a dedicated `Makefile` in `c-gpu-1/` for building the GPU-based test.
attogram
changed the title
- Adds a C implementation of the `password_hash` benchmark to the `c-php-sourced/` directory. - The C code is based on the logic from the official PHP source repository, as per the requirements. - Includes a comment with a URL pointing to the original source file. - Uses the `argon2i_hash_raw` function from the `libargon2` library to replicate the hashing behavior.
- Adds a C implementation of the `sha256` benchmark to the `c-php-sourced/` directory. - This version uses the OpenSSL `libcrypto` library, which is consistent with the original `c/sha256.c` test. - A comment has been added to the file explaining that this approach was taken because isolating the exact source for PHP's `hash()` function is non-trivial.
- Adds a C implementation of the `gmp_add` benchmark to the `c-php-sourced/` directory. - This version is adapted from the existing C code in `c-1/` and updated to use `clock_gettime` for consistency with other tests in this method.
- Adds a C implementation of the `gmp_div` benchmark to the `c-php-sourced/` directory. - This version is adapted from the existing C code in `c-1/` and updated to use `clock_gettime` for consistency with other tests in this method.
This pull request creates the initial directory structure for the benchmark reorganization. It adds the
c-1,c-gpu-1, andc-php-sourceddirectories, which will be populated in subsequent commits.PR created automatically by Jules for task 9447300781513695811 started by @attogram