Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash when in deleted directory #2599

Open
1 task done
aes opened this issue Feb 25, 2025 · 2 comments
Open
1 task done

[Bug]: Crash when in deleted directory #2599

aes opened this issue Feb 25, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@aes
Copy link

aes commented Feb 25, 2025

What did you expect to happen?

Nothing, I guess? Or a warning.

Steps to reproduce:

  1. mkdir fnord
  2. cd fnord
  3. rmdir ../fnord
  4. atuin doctor

What happened?

$ xxxx xxx xxx
Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16

Later, when reproducing:

$ Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16
Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16
zsh: command not found: Error:
zsh: command not found: Caused
zsh: command not found: 0:
zsh: unknown sort specifier
zsh: command not found: Location:
zsh: no such file or directory: crates/atuin-client/src/settings.rs:834:16

Atuin doctor output

$ atuin doctor
Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16
Error: could not load client settings

Caused by:
   0: cloud not load config file
   1: No such file or directory (os error 2)

Location:
    crates/atuin-client/src/settings.rs:834:16

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aes aes added the bug Something isn't working label Feb 25, 2025
@aes
Copy link
Author

aes commented Feb 25, 2025

I can't believe how this project has come from nowhere and become something that I take so for granted so quickly. I wouldn't call it a 'game changer' exactly, but it is a noticeable step change for the better. It makes my life a little cozier. Thank you!

@aes
Copy link
Author

aes commented Feb 25, 2025

Notice how there's also nothing sensible to do here, since your shell is in a borked state. (pwd is deleted)

The best you can do is probably to notice this condition and either silently quit or warn the user. (I recommend warning, but with an (inevitable) option to silence it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant