Un-ossify the build system #36
Draft
+14,651
−71,186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This escalated quickly. Roughly: I started by just wanting to collapse the workspaces. In moving the yarn lockfiles around, I triggered an upgrade of one package or another, which moved to ESM, which the create-react-app version of Webpack wasn't able to parse. You're kinda stuck with what CRA gives you as far as versions of things go.
That prompted a move to Vite, which shouldn't have been that destructive a change, except that we were doing a bunch of non-standard stuff. I had to fix a bunch of typescript issues that came with the new typescript version, which also included upgrading how we're doing protobuf generation. I also simplified the build process as much as I could by moving things into the
publicdir and letting vite copy them around.Changes
I'm gonna annotate this to call out the most relevant bits.
Testing
See that things are green and check out the preview to see that it works as desired.