feat: add timezone #1409
Merged
feat: add timezone #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mario99logic - make sure that the tests are passing and rebase this branch on top of main. |
RonenMars
requested changes
Nov 18, 2025
Contributor
RonenMars
left a comment
RonenMars
left a comment
There was a problem hiding this comment.
Generally, it's a good start in the frontend world, but it has critical issues that must be addressed.
Also, missing E2E tests:
- Create a scheduler trigger with timezone selection
- Edit scheduler trigger and change timezone
- Verify the timezone is saved and displayed correctly
- Test default UTC timezone behavior
- Test form validation with/without timezone
src/components/organisms/configuration/triggers/formParts/scheduler.tsx
Outdated
Show resolved
Hide resolved
mario99logic
force-pushed
the
mario/ui-1940-add_timezone
branch
from
736f4f3 to
5fd094f
Compare
mario99logic
force-pushed
the
mario/ui-1940-add_timezone
branch
from
f040135 to
85fc174
Compare
RonenMars
reviewed
Nov 23, 2025
Contributor
|
Please run |
mario99logic
force-pushed
the
mario/ui-1940-add_timezone
branch
from
68c3a5c to
5499f24
Compare
mario99logic
force-pushed
the
mario/ui-1940-add_timezone
branch
from
5499f24 to
6469626
Compare
RonenMars
approved these changes
Nov 25, 2025
|
🎉 This release is now available on GitHub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
UI-1940
What type of PR is this? (check all applicable)
Add timezone to trigger of type scheduler