-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporse oppsite of .getElemId(index) #198
Comments
Oh crap. I had thought it would be easy, but I misremembered some of the details. Well, there is an easy method, which is to do a linear scan over the What I had in mind was to use the It's annoying that the frontend/backend split is making this difficult. Perhaps we need to put a better data structure like the skiplist in the frontend, but I had been trying to keep the frontend as lightweight as possible, otherwise what's the point of splitting the two? |
That’s actually not going to work either, because deleted characters are no longer in there |
Oh yes, you're right. I think the backend skiplist retains deleted element IDs and calculates indexes correctly (deleted elements can be looked up by element ID, but don't count towards indexes), but I'm still not sure how to give the frontend access to that information. |
I'm pretty lost in the code base, can't seem to figure out where do frontend / backend even communicate. @ept would you mind providing a bit more insights on how I can go about this ? At this point I'm open to some dirty hacks so I can make more progress on my editor prototype & learn more about how things work internally in the process. |
I just did some experimentation, and realised that I had mis-remembered: in fact, the skip list does not keep track of deleted elements either. But the backend opset combined with the skip list has enough information to convert an element ID into an index, handling deleted elements. Here's a very dirty hack to get you started: let doc = Automerge.from({text: new Automerge.Text('hello')})
let backend = Automerge.Frontend.getBackendState(doc)
let elemIds = backend.getIn(['opSet', 'byObject', Automerge.getObjectId(doc.text), '_elemIds'])
elemIds.keyOf(0) // '404582db-07e8-40ce-b782-8ece5eca337a:1'
elemIds.indexOf(elemIds.keyOf(3)) // 3 That In order to find the index of a deleted element, we search for the closest predecessor element that exists, and look up the index of that. The algorithm for this is at op_set.js:159–167. Hope you can get it working; please let me know if you get stuck. |
Closing this as there's nothing further to be done for now; please re-open in case of problems. |
As per suggestion in #193
I attempted to add
.getElemIndex(id)
method toText.prototype
but I'm afraid I failed to figure out how to do it.contex.js
does not seem to have anything relevant as far as I can tell.I would love to help address this but I'd need some mentoring to get it done.
The text was updated successfully, but these errors were encountered: