Skip to content

Conversation

@cliping
Copy link
Contributor

@cliping cliping commented Nov 28, 2025

Increase the hugepage memory to avoid 'preallocating memory failed' error.

Summary by CodeRabbit

  • Tests
    • Updated memory configuration parameters for NUMA-related test scenarios to reflect improved resource allocation settings.

✏️ Tip: You can customize this high-level summary in your review settings.

Increase the hugepage memory to avoid 'preallocating memory failed'
error.

Signed-off-by: lcheng <lcheng@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

A configuration parameter in the migration NUMA test file is updated: the hugepage_mem value is doubled from 4194304 to 8388608 in the migration_numatune.cfg file. This is a single-line modification to a test configuration affecting the hugepage memory allocation for NUMA/memory setup in migration tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single configuration parameter modification
  • No logic, structural changes, or code alterations
  • Test configuration file only

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing hugepage memory configuration. It directly corresponds to the file modification in migration_numatune.cfg.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbbb993 and 6c50468.

📒 Files selected for processing (1)
  • libvirt/tests/cfg/migration/migration_numa/migration_numatune.cfg (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Python 3.12
  • GitHub Check: Python 3.11
  • GitHub Check: Python 3.9
  • GitHub Check: Python 3.8
🔇 Additional comments (1)
libvirt/tests/cfg/migration/migration_numa/migration_numatune.cfg (1)

33-33: Hugepage size increase looks reasonable; ensure host capacity matches.

Doubling hugepage_mem to 8,388,608 KiB is consistent with a 4 GiB guest plus overhead and should help avoid the preallocation failure. Just make sure the test environments actually have enough hugepages reserved so this larger allocation doesn’t cause unrelated setup failures.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cliping
Copy link
Contributor Author

cliping commented Nov 28, 2025

Before:
VM 'avocado-vt-vm1' failed to start: error: Failed to start domain 'avocado-vt-vm1' error: internal error: QEMU unexpectedly closed the monitor (vm='avocado-vt-vm1'): 2025-11-20T13:13:52.107541Z qemu-kvm: qemu_prealloc_mem: preallocating memory failed: Bad address

After:
(1/1) type_specific.io-github-autotest-libvirt.migration.numa.numatune.mem_mode_interleave.hugepage: PASS (225.34 s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant