Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct signatures for a specific p-chain height #501

Open
iansuvak opened this issue Sep 26, 2024 · 1 comment · May be fixed by #506
Open

Construct signatures for a specific p-chain height #501

iansuvak opened this issue Sep 26, 2024 · 1 comment · May be fixed by #506
Assignees
Labels
enhancement New feature or request

Comments

@iansuvak
Copy link
Contributor

Context and scope
CreateSignedMessage right now assumes that the ProposerVM P-Chain height for the destination chain is the latest height. This is not a valid assumption at all times and it should optionally accept a specific height for which to create a signature since any changes in the signing subnets validator set as viewed by the destination chain (via p-chain) can make the aggregated signature invalid as the validator bit set would change in those cases.

Discussion and alternatives

  • Should we expose this in the Signature aggregator interface?
  • Ideally we should be able to accept a destination chain id on the api side and translate that to a likely valid p-chain height.

Open questions

@iansuvak iansuvak added the enhancement New feature or request label Sep 26, 2024
@iansuvak iansuvak self-assigned this Sep 26, 2024
@iansuvak iansuvak linked a pull request Oct 2, 2024 that will close this issue
@cam-schultz cam-schultz added this to the Etna compatibility milestone Oct 28, 2024
@cam-schultz
Copy link
Collaborator

As an alternative to #506 , we may want to instead integrate the following Avalanchego changes once they are merged:

This will allow us to fetch the valdiator set that will be used to verify signatures on the L1 side directly from the P-Chain. We will also be able to connect to validators of any L1 without requiring manual tracking or L1-specific API nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants