Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainHeaderReader depends on state #1262

Open
darioush opened this issue Jul 31, 2024 · 0 comments
Open

ChainHeaderReader depends on state #1262

darioush opened this issue Jul 31, 2024 · 0 comments
Labels
cleanup help wanted Extra attention is needed

Comments

@darioush
Copy link
Collaborator

Becuase of: https://github.com/ava-labs/subnet-evm/blob/master/consensus/consensus.go#L58-L63
(GetFeeConfigAt, GetCoinbaseAt), methods in the ChainHeaderReader end up depending on state.

We should try to keep header verification separate from verification that requires state / block, so likely some refactoring to move this verification to a different location.
@darioush darioush added help wanted Extra attention is needed cleanup labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darioush