Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avahi.org/download has no file index #2

Open
lathiat opened this issue Dec 6, 2023 · 11 comments · May be fixed by #3
Open

avahi.org/download has no file index #2

lathiat opened this issue Dec 6, 2023 · 11 comments · May be fixed by #3

Comments

@lathiat
Copy link
Contributor

lathiat commented Dec 6, 2023

Unlike the previous host, avahi.org/download has no index of files.

Some distributions such as Debian (using debian's debian/watch) file rely on this for their automatic checking of new releases.

We may need to fix this (it's possible to generate such an index with GitHub actions) and/or formalise a move to using GitHub releases or similar.

I know Debian does this, I am not sure who if anyone else does this.

@evverx
Copy link
Member

evverx commented Dec 6, 2023

I think it should be possible for Debian to switch to GitHub by analogy with https://salsa.debian.org/systemd-team/systemd/-/blob/debian/master/debian/watch. @mbiebl I wonder if it would be possible to switch https://salsa.debian.org/utopia-team/avahi/-/blob/debian/master/debian/watch from avahi.org?

@lathiat
Copy link
Contributor Author

lathiat commented Dec 6, 2023

Yeah they'd totally be up to switch I imagine, I guess we just need to decide if we want to do that or not.

@evverx
Copy link
Member

evverx commented Dec 6, 2023

To judge from https://salsa.debian.org/utopia-team/avahi/-/commit/893a2769f18f4c444a186872a329bc5272e9598b Debian switched to GitHub and then switched back to avahi.org due to I assume that bug where GitHub messed up checksums. That change was reverted by GitHub so it should probably be safe to switch back.

I think GitHub releases should be good enough. If someone really needs the download folder they can implement and maintain that action themselves.

@mbiebl
Copy link

mbiebl commented Dec 6, 2023

https://wiki.debian.org/debian/watch#GitHub has some background

I.e. the download links being JS based and one approach is to use api.github.com. The problem is, that access to api.github.com is rate limited.

@mbiebl
Copy link

mbiebl commented Dec 6, 2023

That said, yes, we can adjust debian/watch to use github directly (whether it be releases or tags).

Just curious: Is it still planned to release full make dist tarballs or only git tag snapshots?

@evverx
Copy link
Member

evverx commented Dec 6, 2023

Personally I'd switch to snapshots (and maybe signed tags eventually) because it's easier to maintain. That being said if I used tarballs I wouldn't be happy about this because I don't trust snapshots generated by GitHub :-) I guess it depends on avahi/avahi#449.

@mbiebl
Copy link

mbiebl commented Dec 6, 2023

Yeah, unfortunately the Debian repository is still tarball based and I'm aware of the shortcomings of git archive / github snapshots.
So, I would prefer official release tarballs, but if it's too much effort, then Debian will certainly cope.

@mbiebl
Copy link

mbiebl commented Dec 6, 2023

Btw, nice to see the @avahi project being in place now!

@mbiebl
Copy link

mbiebl commented Dec 7, 2023

I staged those changes for now:

diff --git a/debian/watch b/debian/watch
index fbfcf52d..f0c0dce5 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,2 +1,4 @@
 version=4
-https://avahi.org/download/@PACKAGE@@ANY_VERSION@@ARCHIVE_EXT@
+opts="searchmode=plain" \
+  https://api.github.com/repos/avahi/@PACKAGE@/releases \
+  https://github.com/avahi/@PACKAGE@/releases/download/v(?:\d[\d.]*)/@PACKAGE@@ANY_VERSION@@ARCHIVE_EXT@

This assumes that there will still be releases going forward.

@Its-Just-Nans Its-Just-Nans linked a pull request Dec 7, 2023 that will close this issue
@lathiat
Copy link
Contributor Author

lathiat commented Dec 8, 2023

I think publishing release tarballs is still fine, you can upload them to the GitHub release no problem. Is there a best practice other projects have moved towards to continue or avoid doing that?

If we wanted to stop there'd be a bit of work to do I think since the make dist generates some outputs such as teh docs, autoconf, etc.

@evverx
Copy link
Member

evverx commented Dec 8, 2023

Is there a best practice other projects have moved towards to continue or avoid doing that?

I think it depends on the project. Some projects like systemd release git snapshots but it isn't exactly friendly to distros consuming tarballs (partly because those autogenerated snapshots can't be signed).

FWIW I agree that it would be better to keep releasing "make dist" tarballs.

(I don't think they should be kept in two different places though in the sense that I don't think the "download" folder at avahi.org is needed any more)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants