Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legacy.py missing price per asset when getting assigned on an option #2

Open
MiErnst opened this issue Sep 22, 2024 · 1 comment
Open

legacy.py missing price per asset when getting assigned on an option #2

MiErnst opened this issue Sep 22, 2024 · 1 comment
Assignees
@avion23

Comments

@MiErnst
Copy link

MiErnst commented Sep 22, 2024

Hi, thanks for the script. Unfortunately, it produced some issues which I fixed manually at the end.

2021-07-30T23:00:00+0200,Receive Deliver,Sell to Close,SELL_TO_CLOSE,X,Equity,Sell to Close 1000 X @ 25.00,"25,000.00",1000,25.00,--,-5.25,,,,,,,,USD

produced this one:

07/30/2021 11:00 PM,Receive Deliver,Sell to Close,X,Sell,Close,1000,,,,,5.250,25000,Sell to Close 1000 X @ 25.00,Individual...39

It misses the value per assets. Should Be:

07/30/2021 11:00 PM,Receive Deliver,Sell to Close,X,Sell,Close,1000,,,,25.0,5.250,25000,Sell to Close 1000 X @ 25.00,Individual...39
@avion23 avion23 self-assigned this Sep 22, 2024
avion23 pushed a commit that referenced this issue Sep 22, 2024
Ref #2: legacy.py missing price per asset when getting assigned on an…
2e33007 
… option
@avion23
Copy link
Owner

avion23 commented Sep 22, 2024

Do you think 2e33007 is a good fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avion23 avion23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MiErnst @avion23