Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenStruct from the codebase #3245

Open
adrianthedev opened this issue Sep 14, 2024 · 5 comments
Open

Remove OpenStruct from the codebase #3245

adrianthedev opened this issue Sep 14, 2024 · 5 comments
Assignees
@Yash-Singh-Pathania
Labels
Good first issue Good for newcomers Help wanted We could use some help with this Refactor

Comments

@adrianthedev
Copy link
Collaborator

Context

OpenStruct seems to be "deprecated" and not that performant.
Let's try to replace it with Data (carefull. it's not mutable).
@adrianthedev adrianthedev added Help wanted We could use some help with this Good first issue Good for newcomers Refactor labels Sep 14, 2024
@Yash-Singh-Pathania
Copy link
Contributor

hi @adrianthedev would you be okay assigning this to me .

@adrianthedev
Copy link
Collaborator Author

Done! Thanks @Yash-Singh-Pathania!

@adrianthedev
Copy link
Collaborator Author

Maybe this is a good alternative?
https://api.rubyonrails.org/classes/ActiveSupport/OrderedOptions.html

@Yash-Singh-Pathania
Copy link
Contributor

@adrianthedev Makes sense. I'll try to implement it and have the pull request ready by today or the day after. Thanks for the help!

@Yash-Singh-Pathania Yash-Singh-Pathania mentioned this issue Oct 4, 2024
Open
4 tasks
@Yash-Singh-Pathania
Copy link
Contributor

@adrianthedev : https://github.com/avo-hq/avo/actions/runs/11178246617/job/31075442563?pr=3307
could you please help me with the test cases ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yash-Singh-Pathania Yash-Singh-Pathania

Labels
Good first issue Good for newcomers Help wanted We could use some help with this Refactor
Projects
Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrianthedev @Yash-Singh-Pathania