Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: customizable first sorting option #3309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: customizable first sorting option #3309

wants to merge 1 commit into from
+12 −6

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Oct 5, 2024 •
edited
Loading

Description

Fixes #3260

Me working on this feature:
https://www.loom.com/share/da337fcece7f42b9ab61d96a75e65df0

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Enable the configuration with config.first_sorting_option = :asc in the intializer
  2. Got to the index view
  3. sort a column
  4. observe that the sequence is asc, desc, then reset

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 5, 2024

Code Climate has analyzed commit 1ecf863 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator Author

@Paul-Bob, please add tests 😅🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Awaiting requested review from Paul-Bob

Assignees

@Paul-Bob Paul-Bob

Labels
Feature hacktoberfest Needs Tests
Projects
Issues
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default sort_direction ASC when clicking column
2 participants
@adrianthedev @Paul-Bob