-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor package #14
Refactor package #14
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Type
enhancement, tests
Description
Calculation
class.Calculation
class.Changes walkthrough 📝
6 files
calculation_library.ts
Refactor calculation library to remove unused imports and references.
src/calculation_suite/calculations/calculation_library.ts
CALCULATIONS
object to exclude commented-out calculations.asrs.ts
Refactor ASRS calculation to use new Calculation class.
src/calculation_suite/calculations/asrs/asrs.ts
Calculation
class.10_meter_walk_test.ts
Refactor 10 Meter Walk Test calculation to use new Calculation class.
src/calculation_suite/calculations/10_meter_walk_test/10_meter_walk_test.ts
Calculation
class.
bmi.ts
Refactor BMI US calculation to use new Calculation class.
src/calculation_suite/calculations/bmi/us/bmi.ts
Calculation
class.beck.ts
Refactor Beck calculation to use new Calculation class.
src/calculation_suite/calculations/beck/beck.ts
Calculation
class.calculations.controller.ts
Update API controller to support new Calculation class.
src/api/v1/controllers/calculations.controller.ts
Calculation
class in API endpoints.inputSchema
.10 files
asrs.test.ts
Refactor ASRS test to use new Calculation class.
src/calculation_suite/calculations/asrs/asrs.test.ts
Calculation
class.InvalidInputsError
withZodError
for validation.acro.test.ts
Update Acro test to use new Calculation class.
src/calculation_suite/calculations/acro/acro.test.ts
Calculation
class for testing.InvalidInputsError
withZodError
for validation.cdlqi.test.ts
Simplify and clean up CDLQI test cases.
src/calculation_suite/calculations/cdlqi/cdlqi.test.ts
return
statements.10_meter_walk_test.test.ts
Refactor 10 Meter Walk Test to use new Calculation class.
src/calculation_suite/calculations/10_meter_walk_test/10_meter_walk_test.test.ts
Calculation
class.InvalidInputsError
withZodError
for validation.beck.test.ts
Refactor Beck test to use new Calculation class.
src/calculation_suite/calculations/beck/beck.test.ts
Calculation
class for testing.InvalidInputsError
withZodError
for validation.blcs.test.ts
Refactor BLCS test to use new Calculation class.
src/calculation_suite/calculations/blcs/blcs.test.ts
Calculation
class.InvalidInputsError
withZodError
for validation.bwcs.test.ts
Refactor BWCS test to use new Calculation class.
src/calculation_suite/calculations/bwcs/bwcs.test.ts
Calculation
class.InvalidInputsError
withZodError
for validation.bmi.test.ts
Refactor BMI Metric test to use new Calculation class.
src/calculation_suite/calculations/bmi/metric/bmi.test.ts
Calculation
class for testing.InvalidInputsError
withZodError
for validation.audit.test.ts
Simplify and clean up Audit test cases.
src/calculation_suite/calculations/audit/audit.test.ts
return
statements.bmi.test.ts
Refactor BMI US test to use new Calculation class.
src/calculation_suite/calculations/bmi/us/bmi.test.ts
Calculation
class for testing.InvalidInputsError
withZodError
for validation.46 files
acro.ts
...
src/calculation_suite/calculations/acro/acro.ts
...
age_calc.test.ts
...
src/calculation_suite/calculations/age_calc/age_calc.test.ts
...
bmi.ts
...
src/calculation_suite/calculations/bmi/metric/bmi.ts
...
calculate_subscale_scores.ts
...
src/calculation_suite/calculations/asrs/helpers/calculate_subscale_scores.ts
...
calculate_part_scores.ts
...
src/calculation_suite/calculations/asrs/helpers/calculate_part_scores.ts
...
Calculation.ts
...
src/api/shared/classes/Calculation.ts
...
age_calc.ts
...
src/calculation_suite/calculations/age_calc/age_calc.ts
...
calculate_scores.ts
...
src/calculation_suite/calculations/acro/helpers/calculate_scores.ts
...
calculation_library.test.ts
...
src/calculation_suite/calculations/calculation_library.test.ts
...
acro_inputs.ts
...
src/calculation_suite/calculations/acro/definition/acro_inputs.ts
...
asrs_output.ts
...
src/calculation_suite/calculations/asrs/definition/asrs_output.ts
...
bwcs.ts
...
src/calculation_suite/calculations/bwcs/bwcs.ts
...
blcs.ts
...
src/calculation_suite/calculations/blcs/blcs.ts
...
beck_inputs.ts
...
src/calculation_suite/calculations/beck/definition/beck_inputs.ts
...
asrs_inputs.ts
...
src/calculation_suite/calculations/asrs/definition/asrs_inputs.ts
...
calculations.service.ts
...
src/api/shared/services/calculations.service.ts
...
10_meter_walk_test_output.ts
...
src/calculation_suite/calculations/10_meter_walk_test/definition/10_meter_walk_test_output.ts
...
acro_output.ts
...
src/calculation_suite/calculations/acro/definition/acro_output.ts
...
blcs_inputs.ts
...
src/calculation_suite/calculations/blcs/definition/blcs_inputs.ts
...
bwcs_inputs.ts
...
src/calculation_suite/calculations/bwcs/definition/bwcs_inputs.ts
...
parse_readme_to_html.ts
...
src/calculation_suite/helper_functions/parse_readme_to_html/parse_readme_to_html.ts
...
bmi.schema.ts
...
src/calculation_suite/calculations/bmi/us/bmi.schema.ts
...
calculations.types.ts
...
src/types/calculations.types.ts
...
bmi.schema.ts
...
src/calculation_suite/calculations/bmi/metric/bmi.schema.ts
...
calculations.controller.ts
...
src/api/v2/controllers/calculations.controller.ts
...
10_meter_walk_test_inputs.ts
...
src/calculation_suite/calculations/10_meter_walk_test/definition/10_meter_walk_test_inputs.ts
...
bmi_form.ts
...
src/calculation_suite/calculations/bmi/metric/bmi_form.ts
...
bmi_form.ts
...
src/calculation_suite/calculations/bmi/us/bmi_form.ts
...
age_calc_inputs.ts
...
src/calculation_suite/calculations/age_calc/definition/age_calc_inputs.ts
...
age_calc_output.ts
...
src/calculation_suite/calculations/age_calc/definition/age_calc_output.ts
...
bwcs_output.ts
...
src/calculation_suite/calculations/bwcs/definition/bwcs_output.ts
...
blcs_output.ts
...
src/calculation_suite/calculations/blcs/definition/blcs_output.ts
...
beck_output.ts
...
src/calculation_suite/calculations/beck/definition/beck_output.ts
...
index.ts
...
src/calculation_suite/calculations/10_meter_walk_test/definition/index.ts
...
index.ts
...
src/calculation_suite/calculations/asrs/definition/index.ts
...
index.ts
...
src/calculation_suite/calculations/acro/definition/index.ts
...
calculation_library_v3.ts
...
src/calculation_suite/calculations/calculation_library_v3.ts
...
index.ts
...
src/calculation_suite/calculations/age_calc/definition/index.ts
...
index.ts
...
src/calculation_suite/calculations/bmi/index.ts
...
index.ts
...
src/calculation_suite/calculations/bwcs/definition/index.ts
...
index.ts
...
src/calculation_suite/calculations/blcs/definition/index.ts
...
index.ts
...
src/calculation_suite/calculations/beck/definition/index.ts
...
index.ts
...
src/calculation_suite/helper_functions/parse_readme_to_html/index.ts
...
package-lock.json
...
package-lock.json
...
package.json
...
package.json
...
jest.config.cjs
...
jest.config.cjs
...