Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecr-login with fips enabled #401

Open
srijitncoupa opened this issue Jan 19, 2023 · 3 comments
Open

ecr-login with fips enabled #401

srijitncoupa opened this issue Jan 19, 2023 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@srijitncoupa
Copy link

Problem:

Currently, ecr-login utilizes the registries listed at .dkr.ecr..amazonaws.com to log in. I'm curious as to whether the current release of the git hub action supports login to the fips-based ecr .dkr.ecr-fips..amazonaws.

@arjraman arjraman added the feature-request A feature should be added or improved. label Jan 31, 2023
@devon-manifest
Copy link

@srijitncoupa FYI, I also needed this capability, so I added the option in a fork and tossed up a PR. Here's hoping 🤞

@dotCipher
Copy link

Would love to see this 👍🏻

@tom-engineering
Copy link

You can utilise the AWS_USE_FIPS_ENDPOINT environment variable to use FIPS endpoints:

jobs:
  my-job:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: aws-actions/configure-aws-credentials@v4
        with:
          aws-region: {{ env.AWS_REGION }}
          role-to-assume: {{ secrets.AWS_IAM_ROLE }}
      - id: login-ecr
        env:
          AWS_USE_FIPS_ENDPOINT: true
        uses: aws-actions/amazon-ecr-login@v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

5 participants