Skip to content

Commit f8f4e91

Browse files
authored
Update index.js
1 parent b408ba3 commit f8f4e91

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

index.js

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -975,20 +975,20 @@ async function uploadToS3(zipFilePath, bucketName, s3Key, region) {
975975
region,
976976
customUserAgent: `LambdaGitHubAction/${version}`
977977
});
978-
// let bucketExists = false;
979-
// try {
980-
// bucketExists = await checkBucketExists(s3Client, bucketName);
981-
// } catch (checkError) {
982-
// core.error(`Failed to check if bucket exists: ${checkError.name} - ${checkError.message}`);
983-
// core.error(`Error type: ${checkError.name}, Code: ${checkError.code}`);
978+
let bucketExists = false;
979+
try {
980+
bucketExists = await checkBucketExists(s3Client, bucketName);
981+
} catch (checkError) {
982+
core.error(`Failed to check if bucket exists: ${checkError.name} - ${checkError.message}`);
983+
core.error(`Error type: ${checkError.name}, Code: ${checkError.code}`);
984984

985-
// if (checkError.$metadata?.httpStatusCode === 403) {
986-
// throw new Error(`Access denied to S3 bucket`);
987-
// } else {
988-
// throw checkError;
989-
// }
990-
// }
991-
let bucketExists = true;
985+
if (checkError.$metadata?.httpStatusCode === 403) {
986+
throw new Error(`Access denied to S3 bucket`);
987+
} else {
988+
throw checkError;
989+
}
990+
}
991+
992992
if (!bucketExists) {
993993
core.info(`Bucket ${bucketName} does not exist. Attempting to create it...`);
994994
try {
@@ -1031,7 +1031,7 @@ async function uploadToS3(zipFilePath, bucketName, s3Key, region) {
10311031
expectedBucketOwner = await getAwsAccountId(region);
10321032

10331033
if(!expectedBucketOwner) {
1034-
throw new Error("No expected bucket owner specified. Add expected-bucket-owner to workflow.");
1034+
throw new Error("No AWS account ID found.");
10351035
}
10361036

10371037
const input = {
@@ -1063,12 +1063,7 @@ async function uploadToS3(zipFilePath, bucketName, s3Key, region) {
10631063
})}`);
10641064

10651065
if (uploadError.$metadata?.httpStatusCode === 403) {
1066-
// Check for bucket owner mismatch error
1067-
if (uploadError.message && (uploadError.message.includes('ExpectedBucketOwner') || uploadError.message.includes('bucket owner') || uploadError.message.includes('owner mismatch'))) {
1068-
throw new Error(`Access denied: The expected bucket owner (${expectedBucketOwner}) does not match the actual bucket owner. Ensure you're using a bucket from your AWS account or update your IAM permissions.`);
1069-
} else {
1070-
throw new Error('Access denied when uploading to S3. Ensure your IAM policy includes s3:PutObject permission.');
1071-
}
1066+
throw new Error('Access denied when uploading to S3. Ensure your IAM policy includes s3:PutObject permission.');
10721067
}
10731068
throw uploadError;
10741069
}

0 commit comments

Comments
 (0)