-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: upgrade rtn in example app #14641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| :hermes_enabled => flags[:hermes_enabled], | ||
| :fabric_enabled => flags[:fabric_enabled], | ||
| :fabric_enabled => false, | ||
| :new_arch_enabled => false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: whitespace inconsistency. i think the original indentation is 2 spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
| "dependencies": { | ||
| "react": "^18.3.1", | ||
| "react-native": "0.75.5" | ||
| "react": "19.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to upgrade react as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see here.
Description of changes
Currently, we have 3 dependabot issues because of
node-forge@1.3.1. This dependency is pulled in byreact-native@0.75.5. This PR upgradesreact-native@0.75.5toreact-native@0.79.2for the example app which should resolve the dependabot issue since the newer version ofreact-nativedoes not depend uponselfsigned.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.