Skip to content

Conversation

@soberm
Copy link
Contributor

@soberm soberm commented Nov 27, 2025

Description of changes

Currently, we have 3 dependabot issues because of node-forge@1.3.1. This dependency is pulled in by react-native@0.75.5. This PR upgrades react-native@0.75.5 to react-native@0.79.2 for the example app which should resolve the dependabot issue since the newer version of react-native does not depend upon selfsigned.

"@aws-amplify/react-native-example#node-forge@1.3.1"
info Reasons this module exists
   - "_project_#@aws-amplify#react-native-example#react-native#@react-native#community-cli-plugin#@react-native#dev-middleware#selfsigned" depends on it
   - Hoisted from "_project_#@aws-amplify#react-native-example#react-native#@react-native#community-cli-plugin#@react-native#dev-middleware#selfsigned#node-forge"

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@soberm soberm requested a review from a team as a code owner November 27, 2025 12:30
:hermes_enabled => flags[:hermes_enabled],
:fabric_enabled => flags[:fabric_enabled],
:fabric_enabled => false,
:new_arch_enabled => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace inconsistency. i think the original indentation is 2 spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

"dependencies": {
"react": "^18.3.1",
"react-native": "0.75.5"
"react": "19.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to upgrade react as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see here.

@pranavosu pranavosu merged commit 8c43daf into main Nov 29, 2025
40 checks passed
@pranavosu pranavosu deleted the chore/upgrade_rtn_example branch November 29, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants