Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): decode optimistically with paginated list response type #3474

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented Jan 17, 2024

Issue #

#3259

Description

  • decoding the PaginatedList optimistically

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (fix/gh-3259@3d142c1). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##             fix/gh-3259    #3474   +/-   ##
==============================================
  Coverage               ?   68.11%           
==============================================
  Files                  ?     1080           
  Lines                  ?    36377           
  Branches               ?        0           
==============================================
  Hits                   ?    24779           
  Misses                 ?    11598           
  Partials               ?        0           
Flag Coverage Δ
API_plugin_unit_test 67.07% <0.00%> (?)
AWSPluginsCore 64.18% <0.00%> (?)
Amplify 48.10% <0.00%> (?)
Analytics_plugin_unit_test 81.16% <0.00%> (?)
Auth_plugin_unit_test 78.96% <0.00%> (?)
CoreMLPredictions_plugin_unit_test 59.44% <0.00%> (?)
DataStore_plugin_unit_test 81.62% <0.00%> (?)
Geo_plugin_unit_test 70.75% <0.00%> (?)
Logging_plugin_unit_test 63.34% <0.00%> (?)
Predictions_plugin_unit_test 37.16% <0.00%> (?)
PushNotifications_plugin_unit_test 87.13% <0.00%> (?)
Storage_plugin_unit_test 77.51% <0.00%> (?)
unit_tests 68.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 02:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 17, 2024 04:55 — with GitHub Actions Inactive
@5d 5d changed the base branch from main to fix/gh-3259 January 18, 2024 22:16
@5d 5d marked this pull request as ready for review January 18, 2024 22:48
@5d 5d requested a review from a team as a code owner January 18, 2024 22:48
@5d 5d merged commit 61e8b31 into fix/gh-3259 Jan 19, 2024
74 checks passed
@5d 5d deleted the 5d/partial-sync branch January 19, 2024 00:34
thisisabhash added a commit that referenced this pull request Jan 22, 2024
… update retry mechanism for error codes (#3479)

* fix(DataStore): retry on session expired requests

* fix(datastore): Adding secureConnectionFailed as a retryable error (#3475)

* fix(datastore): decode optimistically with paginated list response type (#3474)

* fix(datastore): decode optimistically with paginated list response type

* add unit test cases

* resolve comments

* Update PaginatedListTests.swift

* fix(DataStore): retry on session expired requests (#3477)

* fix(DataStore): retry on session expired requests

* add test

---------

Co-authored-by: Michael Law <1365977+lawmicha@users.noreply.github.com>
Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>
Co-authored-by: Di Wu <github@wudi.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants