-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): decode optimistically with paginated list response type #3474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## fix/gh-3259 #3474 +/- ##
==============================================
Coverage ? 68.11%
==============================================
Files ? 1080
Lines ? 36377
Branches ? 0
==============================================
Hits ? 24779
Misses ? 11598
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AmplifyPlugins/Core/AWSPluginsCoreTests/Sync/PaginatedListTests.swift
Outdated
Show resolved
Hide resolved
… update retry mechanism for error codes (#3479) * fix(DataStore): retry on session expired requests * fix(datastore): Adding secureConnectionFailed as a retryable error (#3475) * fix(datastore): decode optimistically with paginated list response type (#3474) * fix(datastore): decode optimistically with paginated list response type * add unit test cases * resolve comments * Update PaginatedListTests.swift * fix(DataStore): retry on session expired requests (#3477) * fix(DataStore): retry on session expired requests * add test --------- Co-authored-by: Michael Law <1365977+lawmicha@users.noreply.github.com> Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com> Co-authored-by: Di Wu <github@wudi.me>
Issue #
#3259
Description
PaginatedList
optimisticallyGeneral Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.