running validation to catch all issues

Author: katiegoines

.github/workflows/check_pr_for_broken_links.yml

@@ -35,4 +35,4 @@ jobs:
             return await checkDevLinks();
       - name: Fail if broken links have been found
         if: ${{ steps.checkLinks.outputs.result }}
-        run: exit 1
+        run: exit 1 && echo ${{ toJson(steps.checkLinks.outputs.result) }}

.github/workflows/scripts/validate-redirects.js

@@ -1,7 +1,7 @@
 module.exports = {
   invalidRedirects: () => {
     const Ajv = require('ajv');
-    const redirectsImport = require('../../../redirects.json');
+    const redirects = require('../../../redirects.json');
     const ajv = new Ajv();
 
     const schema = {
@@ -31,30 +31,27 @@ module.exports = {
       }
     };
 
-    let redirects = redirectsImport;
     const errors = [];
+    const validate = ajv.compile(schema);
 
     const validateEntries = (redirects) => {
-      const validate = ajv.compile(schema);
       const valid = validate(redirects);
 
       if (!valid) {
         const error = validate.errors[0];
         const invalidEntry =
           JSON.stringify(redirects[error.instancePath.slice(1, -7)]);
         const loc = error.schemaPath.slice(error.schemaPath.indexOf('properties') + 11, -8);
-        const errorMessage = '\n\n' + 'INVALID ENTRY: Please correct the error in the "' + loc +'" property of the following entry: \n' + invalidEntry + '\n\n' + 'ERROR MESSAGE: ' + error.message;
-
-        errors.push(errorMessage)
-        redirects = redirects.splice(error.instancePath.slice(1, -7))
-        
-        validateEntries(redirects)
-      } else if (valid && errors.length > 0) {
-        return errors.stringify();
-      }
-    }
+        const errorMessage = '\n\n' + 'INVALID ENTRY: Please correct the error in the "' + loc +'" property of the following entry: \n' + invalidEntry + '\n' + 'ERROR MESSAGE: ' + error.message;
+        errors.push(errorMessage);
+
+        validateEntries(redirects.splice(parseInt(error.instancePath.slice(1, -7)) + 1));
 
+      } 
+    }
     validateEntries(redirects);
+
+    return errors;
   }
 }
 

.github/workflows/validate_redirects.yml

@@ -28,5 +28,5 @@ jobs:
             const { invalidRedirects } = require('./.github/workflows/scripts/validate-redirects.js');
             return await invalidRedirects();
       - name: Fail if any invalid redirects have been found
-        if: ${{ steps.redirects.outputs.result != 'undefined' }}
+        if: ${{ steps.redirects.outputs.result }}
         run: exit 1 && echo ${{ steps.redirects.outputs.result }}

redirects.json

@@ -5,14 +5,14 @@
 		"status": "301"
 	},
 	{
-		"source": "cli/function/function/",
+		"source": "/cli/function/function/",
 		"target": "/javascript/build-a-backend/functions/set-up-function/",
 		"status": "301"
 	},
 	{
 		"source": "/lib/ssr/ssr/",
 		"target": "/gen1/javascript/prev/build-a-backend/server-side-rendering/",
-		"status": "601"
+		"status": "301"
 	},
 	{
 		"source": "/cli/plugins/",