Skip to content

fix: correct data types for hotswap ECS CLI flags #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dysosmus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct data types for hotswap ECS CLI flags #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/aws-cdk/lib/cli/cli-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,15 +311,15 @@ export async function makeConfig(): Promise<CliConfig> {
'and falls back to a full deployment if that is not possible.',
},
'hotswap-ecs-minimum-healthy-percent': {
type: 'string',
type: 'number',
desc: 'Lower limit on the number of your service\'s tasks that must remain in the RUNNING state during a deployment, as a percentage of the desiredCount',
},
'hotswap-ecs-maximum-healthy-percent': {
type: 'string',
type: 'number',
desc: 'Upper limit on the number of your service\'s tasks that are allowed in the RUNNING or PENDING state during a deployment, as a percentage of the desiredCount',
},
'hotswap-ecs-stabilization-timeout-seconds': {
type: 'string',
type: 'number',
desc: 'Number of seconds to wait for a single service to reach stable state, where the desiredCount is equal to the runningCount',
},
'logs': {
Expand Down
6 changes: 3 additions & 3 deletions packages/aws-cdk/lib/cli/cli-type-registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,15 +518,15 @@
"desc": "Attempts to perform a 'hotswap' deployment, which skips CloudFormation and updates the resources directly, and falls back to a full deployment if that is not possible. Do not use this in production environments"
},
"hotswap-ecs-minimum-healthy-percent": {
"type": "string",
"type": "number",
"desc": "Lower limit on the number of your service's tasks that must remain in the RUNNING state during a deployment, as a percentage of the desiredCount"
},
"hotswap-ecs-maximum-healthy-percent": {
"type": "string",
"type": "number",
"desc": "Upper limit on the number of your service's tasks that are allowed in the RUNNING or PENDING state during a deployment, as a percentage of the desiredCount"
},
"hotswap-ecs-stabilization-timeout-seconds": {
"type": "string",
"type": "number",
"desc": "Number of seconds to wait for a single service to reach stable state, where the desiredCount is equal to the runningCount"
},
"watch": {
Expand Down
12 changes: 6 additions & 6 deletions packages/aws-cdk/lib/cli/parse-command-line-arguments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,17 +550,17 @@ export function parseCommandLineArguments(args: Array<string>): any {
})
.option('hotswap-ecs-minimum-healthy-percent', {
default: undefined,
type: 'string',
type: 'number',
desc: "Lower limit on the number of your service's tasks that must remain in the RUNNING state during a deployment, as a percentage of the desiredCount",
})
.option('hotswap-ecs-maximum-healthy-percent', {
default: undefined,
type: 'string',
type: 'number',
desc: "Upper limit on the number of your service's tasks that are allowed in the RUNNING or PENDING state during a deployment, as a percentage of the desiredCount",
})
.option('hotswap-ecs-stabilization-timeout-seconds', {
default: undefined,
type: 'string',
type: 'number',
desc: 'Number of seconds to wait for a single service to reach stable state, where the desiredCount is equal to the runningCount',
})
.option('watch', {
Expand Down Expand Up @@ -729,17 +729,17 @@ export function parseCommandLineArguments(args: Array<string>): any {
})
.option('hotswap-ecs-minimum-healthy-percent', {
default: undefined,
type: 'string',
type: 'number',
desc: "Lower limit on the number of your service's tasks that must remain in the RUNNING state during a deployment, as a percentage of the desiredCount",
})
.option('hotswap-ecs-maximum-healthy-percent', {
default: undefined,
type: 'string',
type: 'number',
desc: "Upper limit on the number of your service's tasks that are allowed in the RUNNING or PENDING state during a deployment, as a percentage of the desiredCount",
})
.option('hotswap-ecs-stabilization-timeout-seconds', {
default: undefined,
type: 'string',
type: 'number',
desc: 'Number of seconds to wait for a single service to reach stable state, where the desiredCount is equal to the runningCount',
})
.option('logs', {
Expand Down
Loading