-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(lambda): support for application signals layers #36235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(lambda): support for application signals layers #36235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
4beed7a to
ff0f5c3
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Now that I'm looking at the implementation, it could've also been simply a boolean |
ff0f5c3 to
3dfd465
Compare
|
I would like the API to clearly distinguish the wrapper used by Application Signals, but What's the idiomatic way in |
c34111d to
8c10a69
Compare
8c10a69 to
bd016e3
Compare
Issue # (if applicable)
Closes #36190
Reason for this change
I wanted to provide the
aws-cdk-libLambda Function constructs users an easy way to start using Amazon CloudWatch Application Signals.Description of changes
I added new regional facts for the layer ARNs and the methods to find the correct layer for the specified
Runtime, with necessary compatibility checks.Describe any new or updated permissions being added
The usage requires attaching a policy to the Lambda execution IAM Role. I left it intentionally as a manual step, but I want to discuss with the maintainer whether it could be abstracted away. I thought it will be easier around the code?
Description of how you validated changes
Unit and integration tests are covering the implementation.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license