fix(core): temp cleanup does not work with jest #36238
Draft
+47
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our temporary cleanup fix submitted in #36043 doesn't work for tests run with `jest`, because `jest` suppresses the standard Node `exit` event, causing the cleanup to never run. Instead, we introduce a new public static function which people using `jest` can call: ```ts afterAll(CloudAssembly.cleanupTemporaryDirectories); ``` As well as a convenience script to automatically inject this handler into all jest tests: ``` $ jest --setupFilesAfterEnv aws-cdk-lib/testhelpers/jest-autoclean ``` Once this PR has been merged and released we will add the above to all CLI init templates. Closes #802, hopefully for good. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
requested changes
Nov 28, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This was referenced Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re-roll of #36226)
Our temporary cleanup fix submitted in #36043 doesn't work for tests run with
jest, becausejestsuppresses the standard Nodeexitevent, causing the cleanup to never run.Instead, we introduce a new public static function which people using
jestcan call:As well as a convenience script to automatically inject this handler into all jest tests:
Once this PR has been merged and released we will add the above to all CLI init templates.
Closes #802, hopefully for good.