-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serverless.template file sometimes changes package type to Zip from Image #333
Comments
Updated description to include better repro steps |
Hi @benny-yamagata, Thank you for reporting the issue. I am able to reproduce this scenario. When I update the serverless.template
When I explicitly specify the [LambdaFunction(PackageType = LambdaPackageType.Image)] I will further check on why manually updating the Regards, |
Hello @benny-yamagata, I checked with the team to find out that the Any Lambda function property that can be set via the LambdaFunction attribute should be set via the attribute. Therefore, using below setting would be the ideal way to update the default
And I can confirm that this configuration works as expected, kindly confirm if this helps. Regards, |
This issue has not received a response in 5 days. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled. |
Ok makes sense! The other behavior should be documented somewhere, that if you dont set the annotation package type, it will always be changed. Otherwise it looks like phantom changes from nowhere. |
Describe the bug
Occasionally, after building the function locally I will notice a change in my source control tab in VS code for the serverless.template file. It will have changed my package type from image to zip and added additional fields to support it.
Nowhere else in my project is the word zip found, I'm wondering if this is some background process?
Expected Behavior
serverless.template does not change package type.
Current Behavior
serverless.template sometimes changes package type from image to zip. (does not happen the other way around)
Reproduction Steps
dotnet new serverless.annotations
serverless.template
file to changePackageType
toImage
Functions.cs
Possible Solution
No response
Additional Information/Context
No response
Targeted .NET platform
.net8
CLI extension version
Environment details (OS name and version, etc.)
OSX Sonoma 14.6.1
The text was updated successfully, but these errors were encountered: