CommandLineUtils causes MqttClient to be instantiated due to m_internal_client

[sparrowt]

Describe the bug

While running samples/pub_sub/basic_pub_sub I noticed that very early on when it calls Utils::parseSampleInputPubSub(...) -> CommandLineUtils() is causing an MqttClient to be created which causes the default event loop group to be made resulting in 8 new AwsEventLoop threads:

This all seems a bit unnecessary just in order to parse the command line args?

I wonder if this is caused by m_internal_client here in CommandLineUtils.h.

I'm not sure what that is for and searching for it shows no usages, just the single header occurrence.

Commenting out that line and rebuilding resolves the issue - the event loop threads aren't created until later on when Aws::Iot::MqttClient() is explicitly created.

Is m_internal_client meant to be there?

Expected Behavior

No MqttClient or event loop created until explicitly requested.

Current Behavior

MqttClient & event loop threads created during CommandLineUtils construction.

Reproduction Steps

Build & run samples/pub_sub/basic_pub_sub

Possible Solution

Remove m_internal_client assuming it is indeed unused?

Additional Information/Context

No response

SDK version used

39e497d

Environment details (OS name and version, etc.)

Windows 11 23H2 (unlikely to be relevant)

[jmklix]

Thanks for pointing this out. This might have been used in the samples at some point, but it looks unused as of now. Testing before merging this PR: #726

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.