Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK lists Jackson as a dependency #497

Closed
MikeDombo opened this issue Oct 26, 2023 · 2 comments · Fixed by #499
Closed

SDK lists Jackson as a dependency #497

MikeDombo opened this issue Oct 26, 2023 · 2 comments · Fixed by #499
Assignees
@jmklix
Labels
bug This issue is a bug. p3 This is a minor priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@MikeDombo
Copy link
Contributor

Describe the bug

Jackson isn't used by the SDK from what I can tell and it is bringing an older version of jackson core.

Expected Behavior

Don't need jackson

Current Behavior

Depends on jackson

Reproduction Steps

https://github.com/aws/aws-iot-device-sdk-java-v2/blame/b7c1a824a029600d3fc4de91db24a08ebdf04c16/sdk/pom.xml#L77-L79

Possible Solution

No response

Additional Information/Context

No response

SDK version used

Latest

Environment details (OS name and version, etc.)

none
@MikeDombo MikeDombo added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@jmklix jmklix self-assigned this Oct 26, 2023
@jmklix jmklix mentioned this issue Oct 26, 2023
Merged
@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@jmklix jmklix linked a pull request Oct 26, 2023 that will close this issue
remove jackson dependency #499
Merged
@jmklix
Copy link
Member

jmklix commented Oct 26, 2023

Created PR and I will merge when it passes the tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmklix jmklix

Labels
bug This issue is a bug. p3 This is a minor priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove jackson dependency aws/aws-iot-device-sdk-java-v2
2 participants
@MikeDombo @jmklix