Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure behavior per node through annotations #254

Open
olemarkus opened this issue Sep 14, 2020 · 1 comment
Open

Configure behavior per node through annotations #254

olemarkus opened this issue Sep 14, 2020 · 1 comment
Labels
Priority: Medium This issue will be seen by about half of users stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request

Comments

@olemarkus
Copy link

In clusters with multiple ASGs user for different types of workloads, it would be nice to be able to configure more of the NTH behavior through annotations rather than globally for the nodes the given daemonset is running on.
Cluster Autoscaler already has something similar where one can add annotations on nodes and pods preventing evictions/downscale.

For our use case, annotations for whether to cordon or drain is enough (both on maintenance events and spots). But I can imagine some may want something like the safe-to-evict annotation on pod level too.

@haugenj haugenj added the Type: Enhancement New feature or request label Sep 15, 2020
@jillmon jillmon added the Priority: Medium This issue will be seen by about half of users label Feb 11, 2021
@jillmon jillmon added the stalebot-ignore To NOT let the stalebot update or close the Issue / PR label Oct 19, 2021
@jgournet
Copy link

Just found this ticket - and yes, we would really really appreciate the "safe-to-evict" label on pods.
Some of our pods cannot have 2 running instances at the same time (done via a centralized lock file).
currently, NTH holds up a node termination because of that one deployment: the new pod just cannot start while the old one is still running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue will be seen by about half of users stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants