Skip to content

Commit 919f862

Browse files
[integ-test] Relax Check in Memory Based Scheduling Test
The check was asserting job completion even after Slurm configuration changed to use small memory. I don't see any documentation that guarantees incompatible running jobs still succeed Signed-off-by: Hanwen <hanwenli@amazon.com>
1 parent e6a34ec commit 919f862

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/integration-tests/tests/schedulers/test_slurm.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2588,8 +2588,12 @@ def _test_slurm_behavior_when_updating_schedulable_memory_with_already_running_j
25882588
["/var/log/slurmctld.log"],
25892589
[f"node {node} memory is overallocated"],
25902590
)
2591-
slurm_commands.wait_job_running(job_id_1)
2592-
slurm_commands.wait_job_completed(job_id_1)
2591+
try:
2592+
slurm_commands.wait_job_running(job_id_1)
2593+
slurm_commands.wait_job_completed(job_id_1)
2594+
except Exception as e:
2595+
logging.warning("Job %s did not complete as expected", job_id_1)
2596+
logging.warning(e)
25932597

25942598

25952599
def _test_scontrol_reboot_nodes(

0 commit comments

Comments
 (0)