Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PutObject reads underlying stream twice (even with PayloadSigningPolicy::Never) #1688

Closed
2 tasks done
crusader-mike opened this issue Jun 18, 2021 · 1 comment · Fixed by #2826
Closed
2 tasks done

PutObject reads underlying stream twice (even with PayloadSigningPolicy::Never) #1688

crusader-mike opened this issue Jun 18, 2021 · 1 comment · Fixed by #2826
Assignees
@jmklix
Labels
bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@crusader-mike
Copy link

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
When destination endpoint is not HTTPS -- stream passed to PutObject() gets read twice: to calculate a hash (during signature calculation) and to send payload into the socket. This should not happen when payload signing policy is set to Never. This line is responsible for this behaviour.

SDK version number
1.9.44

Platform/OS/Hardware/Device
Windows, Linux

Expected behavior
I expect stream to be read only once if payload is not signed (regardless of the endpoint type).

Additional context
This is a variation of #711
@crusader-mike crusader-mike added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 18, 2021
@wps132230 wps132230 self-assigned this Jun 28, 2021
@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 16, 2022
@jmklix jmklix added needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue labels Mar 8, 2023
@jmklix jmklix self-assigned this Jan 12, 2024
@jmklix jmklix linked a pull request Jan 26, 2024 that will close this issue
Checksum notes rebase #2826
Merged
11 tasks
@github-actions GitHub Actions
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmklix jmklix

Labels
bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checksum notes rebase aws/aws-sdk-cpp
3 participants
@jmklix @wps132230 @crusader-mike