Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileName with unicode charcter CPP AWS SDK #2144

Closed
abhiDev199 opened this issue Oct 17, 2022 · 3 comments
Closed

FileName with unicode charcter CPP AWS SDK #2144

abhiDev199 opened this issue Oct 17, 2022 · 3 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@abhiDev199
Copy link

abhiDev199 commented Oct 17, 2022

I have a requirement where I download the file from S3 bucket to client with a filename which consists of unicode character.
Example:

transfer_manager->DownloadFile(bucket_name, object_name, fileName)

, where filename is filePath/–test--aws––store__–Status%28th–Aug_2022–.txt. After successful execution of DownloadFile the unicode character in filename gets replaced with ?(question mark) and it's saved as �test--aws��store__�Status%28th�Aug_2022�. I am using windows as a client. Using sdk https://github.com/aws/aws-sdk-cpp. Please let me know if I am missing something.

@ajredniwja ajredniwja self-assigned this Oct 17, 2022
@jmklix jmklix transferred this issue from aws/aws-sdk Oct 17, 2022
@jmklix jmklix assigned jmklix and unassigned ajredniwja Oct 17, 2022
@jmklix jmklix added the bug This issue is a bug. label Oct 17, 2022
@jmklix
Copy link
Member

jmklix commented Oct 18, 2022

I think this will be fixed with this PR. It looks like the sdk is encoding the filename when it shouldn't be which is fixed in the PR

@jmklix jmklix added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 18, 2022
@jmklix jmklix added the p2 This is a standard priority issue label Nov 4, 2022
@jmklix
Copy link
Member

jmklix commented Jul 10, 2024

We don't want to change how we handle some characters by introducing the PR I made above. You can find a list of safe and unsafe characters for s3 object keys here. Please let me know if you have any questions about this.

@jmklix jmklix closed this as completed Jul 10, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

4 participants
@jmklix @ajredniwja @abhiDev199 and others