Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-cpp-sdk-s3-crt]: please expose existing aws-c-s3 CopyObject #2477

Closed
1 of 2 tasks
grrtrr opened this issue May 6, 2023 · 3 comments
Closed
1 of 2 tasks

[aws-cpp-sdk-s3-crt]: please expose existing aws-c-s3 CopyObject #2477

grrtrr opened this issue May 6, 2023 · 3 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue

Comments

@grrtrr
Copy link
Contributor

grrtrr commented May 6, 2023

Problem Description

The C++ SDK provides the CopyObject[Async] request for s3 copy operations.
Despite the support for CopyObject in aws-c-s3 since awslabs/aws-c-s3#166, the S3CrtClient is still using the AWSXMLClient for launching CopyObject requests.

This has the following problems:

  1. The AWSXMLClient CopyObject request only supports copying of objects < 5GB.
  2. Users thus have to re-implement most of the aws-c-s3 CopyObject code (initial HeadObject, determine chunk size, parallel UploadPartCopy requests, and handling completion or abort of the multipart upload).
  3. There is an existing issue S3 CopyObject fails with version id #2103 with AWSXMLClient CopyObject, which also affects the CRT code.

Proposed Solution

Please make the existing aws-c-s3 support for CopyObject available as CopyObjectAsync and CopyObject in the S3CrtClient.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@grrtrr grrtrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 6, 2023
@jmklix
Copy link
Member

jmklix commented May 10, 2023

Looking into if we want to re-enable this.

@jmklix jmklix added needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels May 10, 2023
@sbiscigl
Copy link
Contributor

sbiscigl commented Jul 6, 2023

merged your change + our changes for code generation, it should be going out today! thanks for working with us on this

@sbiscigl sbiscigl closed this as completed Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants