Comprehensive option to disable -Werror or respect CXXFLAGS

[ihnorton]

Describe the bug

As far as I can tell, aws-sdk-cpp does not currently provide a way to disable setting -Werror, although some dependencies do (https://github.com/awslabs/aws-c-common/blob/1778c799be82fde844a02e27d59c5a30a1489e90/cmake/AwsCFlags.cmake#L12).

Please introduce a similar option to either disable -Werror, or to force cmake to respect CXXFLAGS and CFLAGS by not post-pending -Werror.

Expected Behavior

Don't set -Werror unconditionally.

Current Behavior

Builds fail when new compiler versions are released with different safety checks. There are many examples in the issue tracker. It takes time to get these fixed and released across all downstream packages, so an escape-hatch is necessary.

Reproduction Steps

n/a please see many prior issues in this repo

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

n/a

Compiler and Version used

gcc 12, but happens with other compilers

Operating System and version

Debian 12

[yasminetalby]

Hello @ihnorton ,

Thank you very much for your submission and feedback.
I see the previous issue submission related to this. I will bring this up for discussion with the team and update you on this issue.

Thank you again for your time and collaboration.

Sincerely,

Yasmine

[sbiscigl]

Added AWS_SDK_WARNINGS_ARE_ERRORS as a cmake arg that defaults to on that you can escape hatch out of it if desired. give a shout if you have any questions or suggestions, thanks for the feedback!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.