Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment error for TransferManager::DownloadToDirectory() #2665

Closed
BofeiCHEN opened this issue Sep 12, 2023 · 3 comments
Closed

Comment error for TransferManager::DownloadToDirectory() #2665

BofeiCHEN opened this issue Sep 12, 2023 · 3 comments
Assignees
@yasminetalby
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue

Comments

@BofeiCHEN
Copy link

Describe the issue

In the comment for TransferManager::DownloadToDirectory(),

bucketName: the name of the S3 bucket to upload to

which is an error, it should be:

bucketName: the name of the S3 bucket to download from

Links

https://github.com/aws/aws-sdk-cpp/blame/53ea0c45ce2bfe2ee5c28a2d9d2211795d4ccc20/src/aws-cpp-sdk-transfer/include/aws/transfer/TransferManager.h#L257
@BofeiCHEN BofeiCHEN added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Sep 12, 2023
@yasminetalby yasminetalby self-assigned this Sep 12, 2023
@yasminetalby yasminetalby removed the needs-triage This issue or PR still needs to be triaged. label Sep 12, 2023
@yasminetalby
Copy link
Contributor

Hello @BofeiCHEN ,

Thank you very much for bringing this up to our attention.

I will update the documentation to accurately describe the SDK behavior.

We appreciate your feedback and time helping us to improve the SDK documentation.

Best regards,

Yasmine

@yasminetalby yasminetalby mentioned this issue Sep 12, 2023
Merged
11 tasks
@yasminetalby yasminetalby added the p3 This is a minor priority issue label Sep 12, 2023
@yasminetalby
Copy link
Contributor

Hello @BofeiCHEN ,

This has been fixed in v1.11.162 of the SDK.

Thank you very much for your collaboration.

Best regards,

Yasmine

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasminetalby yasminetalby

Labels
documentation This is a problem with documentation. p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BofeiCHEN @yasminetalby