Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ARN as DynamoDB Standard Type #3661

Open
1 of 2 tasks
belugabehr opened this issue Dec 30, 2022 · 5 comments · May be fixed by #3674
Open
1 of 2 tasks

Add Support for ARN as DynamoDB Standard Type #3661

belugabehr opened this issue Dec 30, 2022 · 5 comments · May be fixed by #3674
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@belugabehr
Copy link
Contributor

belugabehr commented Dec 30, 2022

Describe the feature

Update DynamoDB client to natively support a new datatype: com.amazonaws.arn.Arn

Use Case

We store many ARNs in our DynamoDB instance related to SQS topics, StepFunctions State Machines, etc. - would be nice for to have native support for ARNs in DynamoDB mapper.

Proposed Solution

Add ARN support to list of standard supported types.

https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-dynamodb/src/main/java/com/amazonaws/services/dynamodbv2/datamodeling/StandardTypeConverters.java#L83

Other Information

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2

JDK version used

JDK 11

Operating System and version

Linux

@belugabehr belugabehr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 30, 2022
@yasminetalby yasminetalby self-assigned this Jan 3, 2023
@yasminetalby
Copy link

Hello @belugabehr ,

Thank you very much for your submission.
It seems that you have submitted a feature request regarding DynamoDBMapper which is a AWS Java SDK V1 but mention using the AWS Java SDK V2.
In the AWS Java SDK V2, the DynamoDBEnhancedClient has replaced the DynamoDBMapper.

Currently the AWS Java SDK Team is focusing on the implementation of parity features and new features for the AWS Java SDK V2 SDK. If you would like to request new feature for the DynamoDB high-level library I would recommend you to look into migration to the AWS Java SDK v2.

Thank you very much for your submission again!
Let me know if you have any further questions or request.

Sincerely,

Yasmine

@yasminetalby yasminetalby added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2023
@belugabehr
Copy link
Contributor Author

@yasminetalby,

Thank you for your consideration and engagement.

The AWS SDK Java v2 is also missing this capability.

https://github.com/aws/aws-sdk-java-v2/tree/master/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter

Thanks.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Jan 4, 2023
@belugabehr belugabehr linked a pull request Jan 7, 2023 that will close this issue
12 tasks
@debora-ito
Copy link
Member

Hi @belugabehr thank you for reaching out.

Right now this feels too much like an edge case to be added to the list of DynamoDB Enhanced standard attribute converters, but we will keep this feature request open and ask for upvotes 👍 from anybody who is interested in seeing this in the SDK. Depending on the interest we will revisit.

You can use the converter as a custom converter in your project, by using the @DynamoDbConvertedBy attribute annotation in your bean class or attributeConverter if you're using StaticTableSchema.

@debora-ito debora-ito added the p3 This is a minor priority issue label Jan 10, 2023
@belugabehr
Copy link
Contributor Author

Related to: #2955, #2416, #1890

@belugabehr
Copy link
Contributor Author

You can use the converter as a custom converter in your project, by using the @DynamoDbConvertedBy attribute annotation in your bean class or attributeConverter if you're using StaticTableSchema.

That's the current workaround, however, we store all kinds of ARNs in our DDB instance, some are even custom to our application. It just seems like ARNs should have much more robust support.

@yasminetalby yasminetalby removed their assignment Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants