Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc incorrect for DocumentTableSchema #3929

Closed
tkhill-AWS opened this issue Apr 20, 2023 · 4 comments
Closed

Javadoc incorrect for DocumentTableSchema #3929

tkhill-AWS opened this issue Apr 20, 2023 · 4 comments
Labels
documentation This is a problem with documentation.

Comments

@tkhill-AWS
Copy link
Contributor

Describe the issue

The following appears in the introductory description of the Javadoc:

DocumentTableSchema specifying primaryKey, sortKey and a customAttributeConverter can be created as below

 DocumentTableSchema documentTableSchema = DocumentTableSchema.builder()
 .primaryKey("sampleHashKey", AttributeValueType.S)
 .sortKey("sampleSortKey", AttributeValueType.S)
 .attributeConverterProviders(customAttributeConverter, AttributeConverterProvider.defaultProvider())
 .build();

However, if you look at the DocumentTableSchema.Builder documentation, the method names are different:

  • addIndexPartitionKey() (not primaryKey())
  • addIndexSortKeyy() (not sortKey())

The description should be fixed to use the actual method names.

Links

DocumentTableSchema

@tkhill-AWS tkhill-AWS added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2023
@debora-ito
Copy link
Member

Acknowledged. Thank you Todd!

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Apr 20, 2023
@anuq
Copy link

anuq commented Aug 23, 2023

I will work on this and submit a PR later.

@debora-ito
Copy link
Member

Fixed via #4348.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

No branches or pull requests

3 participants