Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CHANGELOG.md file does not render #4161

Closed
raymondchen625 opened this issue Jul 4, 2023 · 8 comments
Closed

The CHANGELOG.md file does not render #4161

raymondchen625 opened this issue Jul 4, 2023 · 8 comments
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@raymondchen625
Copy link

Describe the issue

The CHANGELOG.md doesn't render on GitHub. If I try to render it in VSCode, I get error messages like Maximum call stack size exceeded. This seems to be related to the size of the document. My VSCode could render it after cutting down the file size to around 15K lines. But it took quite a while to show the preview.
Might need to break it down into multiple files to keep the changelog rendering sustainable.

Links

https://github.com/aws/aws-sdk-java-v2/blob/master/CHANGELOG.md

@raymondchen625 raymondchen625 added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jul 4, 2023
@debora-ito
Copy link
Member

debora-ito commented Jul 5, 2023

Yes, it's a known issue, apologies for that.

We have in our backlog a task to break the changelog in smaller parts, it's just a matter of prioritizing it against other tasks we need to work on.

Since the changelog is auto generated, we need to figure out a way to programmatically break it in parts that make sense and are easy to use.

Feel free to comment here with suggestions of how we can provide a better changelog.

@debora-ito debora-ito added feature-request A feature should be added or improved. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2023
@DrizzyHendrix
Copy link

bump for visibility, i'm still unable to open the changelog and I'd really like to know the changes going into the SDK...especially with the larger version changes

@millems
Copy link
Contributor

millems commented Jan 18, 2024

@DrizzyHendrix I'm sorry that this hasn't been fixed yet. We're continually trying to improve our prioritization process to avoid paper cuts like this one from going so long unaddressed. You shouldn't have to resort to workarounds, but the raw, unrendered markdown for the changelog is available without the loading issues here: https://raw.githubusercontent.com/aws/aws-sdk-java-v2/master/CHANGELOG.md

@dagnir
Copy link
Contributor

dagnir commented Jan 30, 2024

Hi @DrizzyHendrix I'm working on pushing an update to our release system to publish the changelog updates as GitHub releases which will make viewing the changes for a specific version much easier; please keep an out for this update :). We will keep the text CHANGELOG.md file so changes can be easily searched in aggregate, but will "archive" older entries to a separate file, similar to what we have done for 1.11.x https://github.com/aws/aws-sdk-java/tree/master/changelogs

@DrizzyHendrix
Copy link

Hi @DrizzyHendrix I'm working on pushing an update to our release system to publish the changelog updates as GitHub releases which will make viewing the changes for a specific version much easier; please keep an out for this update :). We will keep the text CHANGELOG.md file so changes can be easily searched in aggregate, but will "archive" older entries to a separate file, similar to what we have done for 1.11.x https://github.com/aws/aws-sdk-java/tree/master/changelogs

Hell yea! Thank you contributors for being responsive

@dagnir
Copy link
Contributor

dagnir commented Feb 6, 2024

Hi @DrizzyHendrix, @raymondchen625, we have now archived older changelog entries to make the main CHANGELOG.md file easier to load/render: https://github.com/aws/aws-sdk-java-v2/blob/master/CHANGELOG.md#22318-2024-02-05. Just as in 1.x, changelogs for older versions can be found in the changelogs. In addition, we're also now creating GitHub releases for each version of the SDK going forward: https://github.com/aws/aws-sdk-java-v2/releases/tag/2.23.18

@raymondchen625
Copy link
Author

Looks nice. Thank you @dagnir

Copy link

github-actions bot commented Feb 6, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

5 participants