Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package IMDS in bundle.jar #4868

Closed
2 tasks
HarshitGupta11 opened this issue Jan 31, 2024 · 3 comments
Closed
2 tasks

Package IMDS in bundle.jar #4868

HarshitGupta11 opened this issue Jan 31, 2024 · 3 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@HarshitGupta11
Copy link

Describe the feature

Currently imds is a separate package and it would be nice to package it inside the bundle.jar. It depends upon aws sdk and the major issue being that some libraries in the bundle are shaded but they are not shaded in imds package leading to Method/ClassNotFoundErrors.

Use Case

It depends upon aws sdk and the major issue being that some libraries in the bundle are shaded but they are not shaded in imds package leading to Method/ClassNotFoundErrors.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.23.5

JDK version used

1.8

Operating System and version

Mac OS X

@HarshitGupta11 HarshitGupta11 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2024
@debora-ito debora-ito added needs-review This issue or PR needs review from the team. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2024
@debora-ito
Copy link
Member

The imds module should be included the bundle jar, I'm changing this to a bug.

@HarshitGupta11 thank you for submitting this.

@debora-ito debora-ito added p2 This is a standard priority issue bug This issue is a bug. and removed needs-review This issue or PR needs review from the team. feature-request A feature should be added or improved. labels Feb 1, 2024
@dagnir
Copy link
Contributor

dagnir commented Feb 6, 2024

This was fixed by #4890.

@dagnir dagnir closed this as completed Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants