Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK contains a copy of slf4j which causes problems for the components that have slf4j on the path for imports. #5108

Closed
HarshitGupta11 opened this issue Apr 16, 2024 · 3 comments · Fixed by #5196
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@HarshitGupta11
Copy link

HarshitGupta11 commented Apr 16, 2024

Describe the bug

Slf4j is shaded in the bundle.jar but there is also a unshaded copy of it present in the jar as well. This causes errors in programs having both slf4j and bundle.jar on the classpath.

The current latest version of the sdk has two LoggerFactory class,

./org/slf4j/LoggerFactory.class
./software/amazon/awssdk/thirdparty/org/slf4j/LoggerFactory.class

Expected Behavior

There should be no unshaded artefacts in the bundle.jar.

Current Behavior

Described above.

Reproduction Steps

A simple unzip of the jar reveals the issue.

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

2.24.6

JDK version used

1.8

Operating System and version

Redhat 8

@HarshitGupta11 HarshitGupta11 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@debora-ito
Copy link
Member

Thank you for reaching out @HarshitGupta11, yes we should fix this. Marking as a bug.

@debora-ito debora-ito added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2024
@HarshitGupta11
Copy link
Author

HarshitGupta11 commented Apr 29, 2024

Hi @debora-ito, Any update on this?

@dagnir dagnir mentioned this issue May 6, 2024
12 tasks
@zoewangg zoewangg mentioned this issue May 7, 2024
12 tasks
Copy link

github-actions bot commented May 7, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants