Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB EnhancedClient UpdateItem backwards incompatible change breaks workflows #5584

Closed
phillipberndt opened this issue Sep 11, 2024 · 3 comments
Assignees
Labels
bug This issue is a bug. dynamodb-enhanced p1 This is a high priority issue

Comments

@phillipberndt
Copy link

phillipberndt commented Sep 11, 2024

Describe the bug

Hi,

we rely on being able to use update operations to create nested structures with the enhanced client. A recent change, #5380, broke this functionality. We now get a

software.amazon.awssdk.services.dynamodb.model.DynamoDbException: The document path provided in the update expression is invalid for update

exception.

We noticed this after the SDK was automatically updated for our service, that is, in a situation where people do not read changelogs to look out for breaking changes. Backwards incompatible changes without version bumps are not a great customer experience. Please consider reverting the change, and reintroducing it in a way that does not break existing code. (e.g. automatically inject a SET that creates maps if they do not exist, or put the entire functionality behind a flag that has to be explicitly toggled in the builder.)

Cheers,
Phillip

Expected Behavior

Existing code relying on being able to create document types in update operations continues to work

Current Behavior

Existing code relying on being able to create document types in update operations broke

Reproduction Steps

See the pull request, we rely exactly on the behavior this changed.

Possible Solution

Please consider reverting the change, and reintroducing it in a way that does not break existing code. (e.g. automatically inject a SET that creates maps if they do not exist, or put the entire functionality behind a flag that has to be explicitly toggled in the builder.)

Additional Information/Context

No response

AWS Java SDK version used

JDK version used

17

Operating System and version

Linux

@debora-ito
Copy link
Member

@phillipberndt thank you for the report, we are reverting #5380 and will follow-up with an investigation.

@debora-ito debora-ito added dynamodb-enhanced p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2024
@debora-ito debora-ito self-assigned this Sep 11, 2024
@bhoradc
Copy link

bhoradc commented Sep 17, 2024

Hi @phillipberndt,

Thanks again for reporting the issue. Closing this as the changes were reverted in SDK version 2.27.24.

Regards,
Chaitanya

@bhoradc bhoradc closed this as completed Sep 17, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. dynamodb-enhanced p1 This is a high priority issue
Projects
None yet
Development

No branches or pull requests

3 participants