Enable setting multipart to true/false by defining it as a custom client context parameter #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent context parameter
davidh44
reviewed
Feb 8, 2024
...anager/src/main/java/software/amazon/awssdk/transfer/s3/internal/TransferManagerFactory.java
Show resolved
Hide resolved
L-Applin
reviewed
Feb 9, 2024
| @@ -271,6 +270,10 @@ | |||
| "CrossRegionAccessEnabled":{ | |||
| "documentation":"Enables cross-region bucket access for this client", | |||
| "type":"boolean" | |||
| }, | |||
| "multipartEnabled":{ | |||
There was a problem hiding this comment.
This also adds the multipart-enable config and method to the sync version of the client, as it adds the method the S3BaseClientBuilder interface which is used by both the sync and async builders:
S3Client client = S3Client.builder()
.multipartEnabled(true) // <--- should not be available on sync builder
.build();
I think we should avoid being able to define this config on the sync client and keep it on the async client only
L-Applin
reviewed
Feb 12, 2024
...anager/src/main/java/software/amazon/awssdk/transfer/s3/internal/TransferManagerFactory.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/software/amazon/awssdk/transfer/s3/internal/TransferManagerLoggingTest.java
Outdated
Show resolved
Hide resolved
…long with multi-part
L-Applin
reviewed
Feb 12, 2024
| + ".MultipartS3AsyncClient")) { | ||
| log.debug(() -> "The provided S3AsyncClient is neither an instance of S3CrtAsyncClient or MultipartS3AsyncClient, " + | ||
| "and thus multipart upload/download feature may not be enabled and resumable file upload may not " + | ||
| "be supported.\n" + "To benefit from maximum throughput, consider using S3AsyncClient.crtBuilder().build() " + |
There was a problem hiding this comment.
very nit-picky: I'd avoid \n in logs
|
There seems to still be a checkstyle violation: |
L-Applin
approved these changes
Feb 12, 2024
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multipart upload can be set as a client configuration parameter and is accessible at the time of instantiation. This allows classes that instantiate the S3AsyncClient to validate this parameter.
Modifications
1)Incorporated multiPartEnabled as a custom client configuration parameter by defining it in customization.config. The codegen module generates getter and setter methods for this parameter.
2) By default, set multipartEnabled = true in the S3AsyncClient
3) Removed code that sets multiPart Enabled on the client directly
Testing
Unit Tests to validate that
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License