DynamoDB Enhanced Client Versioned Record start at 0 #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiesler
force-pushed
the
dynamodb-enhanced-versioned-record-start-at-0
branch
from
770be52
to
cc9f67a
Compare
added 2 commits
September 23, 2024 09:46
The intent is to breakdown the internal logic into smaller methods to make the overall flow more obvious to other developers.
The prior behavior required that a version be initialized with a null value, this required mapper clients to use Integer instead of the int primitive. This change allows clients to explicitly initialize the version to a value which makes it simpler for clients to use primitive values and potentially avoid null pointer exceptions and checks. The default starting value of 0 and increment value of 1 are intended to provide sane defaults that are identical to the existing behavior while enabling clients to have more fine-graned control over how the versioning is managed for their specific use-cases. The current implementation configures the values at the extension level only but the implementation can be expanded to gather the value from the model annotation to customize the values on a per table basis.
akiesler
force-pushed
the
dynamodb-enhanced-versioned-record-start-at-0
branch
from
cc9f67a
to
0af21cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for clients using the DynamoDB Versioned Record Extension to start their versions at
0instead ofnullthus preventing clients from being required to use theIntegertype and instead allowing them to use theintprimitive.This change also makes the extension more flexible by allowing clients to set the starting value and incrementing value if they have a use-case to do so.
Motivation and Context
Most developers would expect a version to start at 0 and increment from their instead of having to have a special case where the value must be initialized to null (see #3894).
Modifications
Updates the internal logic of
VersionedRecordExtensionto accept either a null value or a numeric value equal to the starting value.Testing
Added a unit tests for explicitly setting the version to 0 during initial creation.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License