Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugmanue/rpcv2 merge 2.28.4 snapshot #5604

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sugmanue
Copy link
Contributor

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

* Add support to serialize byte values

* Add tests for byte support

* Address PR comments
* Add support to serialize byte values

* Add RPCv2 protocol core marshalling/unmarshalling

* Address PR comments

* Address PR comments 2

* Address PR comments 3
* Support for operation without input defined

* Fix a checkstyle issue

* Code clean up

* Code clean up 2

* Rewrite the condition to conjunctive normal form
* Add codgen tests

* Address PR comments

* Address PR comments 2

* Add missing class rename

* Add missing AWS_JSON protocol facts

* Account for null protocol case
* Add RPCv2 benchmark tests

* Give the constants name a meaningful name
* Avoid parsing numbers when using RPCv2 protocol
* Refactor to avoid impacting JSON with RPCv2 logic

* Avoid making the unmarshallers depend on timestamp formats

* Avoid streams while unmarshalling

* Fix build failures

* Fix build failures 2
* Improve lookup by marshalling type

* Improve trait lookup using TraitType
@sugmanue sugmanue force-pushed the sugmanue/rpcv2-merge-2.28.4-SNAPSHOT branch from 79eeed6 to 4adfc89 Compare September 17, 2024 23:07
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
49.1% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant