SigV4: Add host header only when not already provided #5608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Our use case is to send SigV4 requests to a transparent proxy to S3. We need to keep the
Host
header in-tact, since we use that for virtual bucket routing. Without these changes, the sdk will not both send a request to a custom endpoint and sign against a customHost
header.No existing issue for sdk-v2, however this issue was reported and closed as a wontfix in sdk-v1: aws/aws-sdk-java#2974
Modifications
Exit early from
SignerUtils#addHostHeader
if aHost
header is present in the request.Testing
mvn install
on localhost; all tests pass except:Example failure, seems completely unrelated to this PR:
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License