-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AmazonS3EncryptionClientV2 can not be subclassed #2494
Comments
@ionapatterson why do you need a subclass of AmazonS3EncryptionClientV2? |
@debora-ito We currently provide a subclass of AmazonS3EncryptionClient that provides enhanced interactions with our Key Store and are looking to migrate to subclassing AmazonS3EncryptionClientV2. |
@ionapatterson To summarize what you described in the issue, AmazonS3EncryptionClientV2 was written with the intention that it not be subclassed. It's a pattern we're moving away from. We have started work on the next generation client encryption, for AWS Java SDK v2 (aws/aws-sdk-java-v2#34). It'd be great if you wanted to provide feedback on features you'd like to see supported, such as key management, materials description etc. |
AmazonS3EncryptionClientV2 can not be subclassed despite lacking final keyword.
AmazonS3EncryptionClientV2 can not be subclassed as it's only constructor method is package-private. Additionally the argument for this constructor is AmazonS3EncryptionClientV2Params which is a package-private class whose only subclass is AmazonS3EncryptionClientV2ParamsWrapper which is final public (preventing extension) and which also has only a package-private constructor.
The text was updated successfully, but these errors were encountered: