ReferenceError: DOMParser is not defined - cloudflare wranger deployment

[srinathreddydudi]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

The recent DomParser change implemented in #7347 seems to break cloudflare's wranger deployments. Wasn't exactly sure if this needs to be addressed on cloudflare end or on this repo. So posting it in both the places.

Bug report on cloudflare: cloudflare/workers-sdk#10755

Error Message:   Uncaught ReferenceError: DOMParser is not defined
    at null.<anonymous> (file:///home/runner/work/*****/node_modules/@aws-sdk/xml-builder/dist-es/xml-parser.browser.js:1:16)

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/aws-sdk-js-v3@v3.894.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

cloudflare wrangler

Reproduction Steps

• install latest version in cloudflare workers code
• push a deployment using wrangler

Observed Behavior

throwing error Uncaught ReferenceError: DOMParser is not defined

Expected Behavior

no error should be reported.

Possible Solution

No response

Additional Information/Context

No response

[kuhe]

The Cloudflare Worker runtime environment isn't one of the target environments of the SDK, so some polyfills are needed.

This depends on whether you want to run the Node.js variant of the AWS SDK or the browser variant.

Browser variant of the AWS SDK

Based on your reported error message, it sounds like you've bundled the AWS SDK with a browser target runtime. To polyfill the DOMParser API, we know of a package called @xmldom/xmldom: https://github.com/xmldom/xmldom, from which you could import DOMParser and load it into the runtime global scope before loading and executing any code from the AWS SDK.

There are several other options for a DOMParser polyfill, but I haven't tested them.

Node.js variant of the SDK (default)

For Node.js-style, run the SDK as-is or bundle it with the Node.js target environment, and then ensure the runtime environment or resolvable imports implement node:* APIs. It looks like Workers have a wide range of Node.js API support: https://developers.cloudflare.com/workers/runtime-apis/nodejs/.

[srinathreddydudi]

The Cloudflare Worker runtime environment isn't one of the target environments of the SDK, so some polyfills are needed.

This depends on whether you want to run the Node.js variant of the AWS SDK or the browser variant.

Browser variant of the AWS SDK

Based on your reported error message, it sounds like you've bundled the AWS SDK with a browser target runtime. To polyfill the DOMParser API, we know of a package called @xmldom/xmldom: https://github.com/xmldom/xmldom, from which you could import DOMParser and load it into the runtime global scope before loading and executing any code from the AWS SDK.

There are several other options for a DOMParser polyfill, but I haven't tested them.

Node.js variant of the SDK (default)

For Node.js-style, run the SDK as-is or bundle it with the Node.js target environment, and then ensure the runtime environment or resolvable imports implement node:* APIs. It looks like Workers have a wide range of Node.js API support: https://developers.cloudflare.com/workers/runtime-apis/nodejs/.

Thank you. Was able to resolve this using the @xmldom/xmldom polyfill. If anyone is looking for a resolution for this, see cloudflare/workers-sdk#10755 (comment)

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.