Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for psr/http-message ^2.0 #2715

Closed
1 of 2 tasks
IanSimpson opened this issue Jun 19, 2023 · 2 comments
Closed
1 of 2 tasks

Missing support for psr/http-message ^2.0 #2715

IanSimpson opened this issue Jun 19, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@IanSimpson
Copy link

Describe the feature

The package psr/http-message v2.0 was released on the 2023-04-17. Could you consider adding support for this version?

Use Case

Compatibility with psr/http-message

Proposed Solution

Update composer json from "psr/http-message": "^1.0" to "psr/http-message": "^1.0 || ^2.0". This will preserve compatibility with PHP5.5 by using the 1.x releases, but ensure users running modern version of PHP can install the latest version of the library.

I don't believe there are any breaking changes in the updated version - the only change noted in the changelog is declared return types.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.273.3

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.1 (all platforms)

@IanSimpson IanSimpson added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2023
@stobrien89
Copy link
Member

Hi @IanSimpson,

Sorry for the confusion. I commented in the other issue, but for those who don't see that— A few classes of ours implement psr7 interfaces, which means allowing V2 is a breaking change for some customer. This will be changing in August. Keep an eye on #2707 for updates.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants