Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: Using ${var} in strings is deprecated #2862

Closed
AJenbo opened this issue Dec 23, 2023 · 3 comments
Closed

Deprecated: Using ${var} in strings is deprecated #2862

AJenbo opened this issue Dec 23, 2023 · 3 comments
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@AJenbo
Copy link

AJenbo commented Dec 23, 2023

Describe the bug

For PHP 8.3 i get the following warning:

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in src/Api/DocModel.php on line 93

https://github.com/aws/aws-sdk-php/blob/326eb6c26e2be9d896c4aeb025e20980c06779af/src/Api/DocModel.php#L93C58-L93C58

Expected Behavior

No warnings or errors

Current Behavior

When this file is loaded php will emit deprecation warnings

Reproduction Steps

php -l src/Api/DocModel.php

Possible Solution

No response

Additional Information/Context

No response

SDK version used

3.288.1

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.3.0
@AJenbo AJenbo added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 23, 2023
@GrahamCampbell
Copy link
Contributor

There is already an open PR to fix this: #2813.

@yenfryherrerafeliz yenfryherrerafeliz added p3 This is a minor priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Dec 27, 2023
@yenfryherrerafeliz
Copy link
Contributor

This issue has been fixed by the following PR. Closing for now.

Thanks!

@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AJenbo @GrahamCampbell @yenfryherrerafeliz