Skip to content

Commit 77ac727

Browse files
committed
Declare dependency on json 2.4.0+
If the gems use `JSON.load_file` and are compatible with Ruby >= 2.5 they must declare that they require `json 2.4.0` otherwise they may get a much older version.
1 parent 10b3bf9 commit 77ac727

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Gemfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
source 'https://rubygems.org'
44

5+
gemspec path: "gems/aws-sdk-core/"
6+
57
gem 'rake', require: false
68
# SDK feature dependencies
79
gem 'aws-crt' if ENV['CRT']
@@ -14,7 +16,6 @@ if defined?(JRUBY_VERSION)
1416
end
1517

1618
# protocol parsers
17-
gem 'json', '2.7.5' if RUBY_VERSION < '3.0.0' # temporary due to json 2.8.0 release
1819
gem 'nokogiri', '>= 1.6.8.1'
1920
gem 'oga'
2021
gem 'rexml'

gems/aws-sdk-core/aws-sdk-core.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Gem::Specification.new do |spec|
1212
spec.require_paths = ['lib']
1313
spec.files = Dir['LICENSE.txt', 'CHANGELOG.md', 'VERSION', 'lib/**/*.rb', 'sig/**/*.rbs', 'ca-bundle.crt']
1414

15+
spec.add_dependency('json', '>= 2.4.0')
1516
spec.add_dependency('jmespath', '~> 1', '>= 1.6.1') # necessary for secure jmespath JSON parsing
1617
spec.add_dependency('aws-partitions', '~> 1', '>= 1.992.0') # necessary for new endpoint resolution
1718
spec.add_dependency('aws-sigv4', '~> 1.9') # necessary for s3 express auth/native sigv4a support

0 commit comments

Comments
 (0)