Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

(quicksight): add paginateListGroups Async Iterator #551

Closed
2 tasks
moltar opened this issue Jun 8, 2023 · 5 comments
Closed
2 tasks

(quicksight): add paginateListGroups Async Iterator #551

moltar opened this issue Jun 8, 2023 · 5 comments
Assignees
Labels
bug Something isn't working quicksight service-api This issue pertains to the AWS API

Comments

@moltar
Copy link

moltar commented Jun 8, 2023

Describe the feature

Would like to have the paginateListGroups Async Iterator function in the QuickSight client.

Other paginate* functions already exist, but paginateListGroups seems to be missing.

Use Case

To paginate.

Proposed Solution

Implement it.

Other Information

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.347.1

Environment details (OS name and version, etc.)

macOS, Node 16

@moltar moltar added feature-request New feature or request needs-triage labels Jun 8, 2023
@RanVaknin RanVaknin added bug Something isn't working and removed feature-request New feature or request labels Jun 8, 2023
@RanVaknin RanVaknin self-assigned this Jun 9, 2023
@RanVaknin
Copy link

Hi @moltar ,

Thanks for letting us know. From what I can tell, non of the list operations for Groups has a paginator:

  • ListGroupMemberships
  • ListUserGroups
  • ListGroups
  • SearchGroups

This is a problem with the service model itself. Even though QuickSight service supports pagination, there is no support for it in the model which means the SDK can't generate the paginators for it.

I have reached out to the service team internally in hopes that they can fix this.

Thanks,
Ran~

P90870794

@RanVaknin RanVaknin transferred this issue from aws/aws-sdk-js-v3 Jun 9, 2023
@RanVaknin RanVaknin added service-api This issue pertains to the AWS API quicksight labels Jun 9, 2023
@RanVaknin
Copy link

Hi @moltar ,

Changes are now live.
Thanks for your contribution 🙂

All the best,
Ran~

@github-actions
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@moltar
Copy link
Author

moltar commented Aug 11, 2023

@RanVaknin is it released already? which version? Thanks.

@RanVaknin
Copy link

Hi @moltar ,

Did not see your comment.

Here is the paginator https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-quicksight/src/pagination/ListGroupsPaginator.ts

This should have been available since 3.376.0

Thanks
Ran~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working quicksight service-api This issue pertains to the AWS API
Projects
None yet
Development

No branches or pull requests

2 participants