Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

CreateOpenIDConnectProviderInput should not require a thumbprint list (ThumbprintList) #563

Closed
sevesalm opened this issue Jul 15, 2023 · 3 comments
Assignees
Labels
bug Something isn't working iam service-api This issue pertains to the AWS API

Comments

@sevesalm
Copy link

CreateOpenIDConnectProviderInput currently requires a non-empty thumbprint list

https://docs.aws.amazon.com/sdk-for-go/api/service/iam/#CreateOpenIDConnectProviderInput

The same requirement is in the API:

https://docs.aws.amazon.com/IAM/latest/APIReference/API_CreateOpenIDConnectProvider.html

You must provide at least one thumbprint when creating an IAM OIDC provider.

However, since July 6th AWS no longer requires these thumbprints (at least for GitHub) as was communicated by this message:

Starting July 6, 2023, AWS began securing communication with GitHub’s OIDC identity provider (IdP) using our library of trusted root Certificate Authorities instead of using a certificate thumbprint to verify the IdP’s server certificate. This approach ensures that your GitHub OIDC configuration behaves correctly without disruption during future certificate rotations and changes. With this new validation approach in place, your legacy thumbprint(s) will remain in your configuration but will no longer be needed for validation purposes.

So: this parameter should be optional.

@jmklix
Copy link
Member

jmklix commented Aug 1, 2023

P95760549

@jmklix
Copy link
Member

jmklix commented Oct 30, 2024

Thumbprints are now optional.

This parameter is optional. If it is not included, IAM will retrieve and use the top intermediate certificate authority (CA) thumbprint of the OpenID Connect identity provider server certificate.

@jmklix jmklix closed this as completed Oct 30, 2024
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working iam service-api This issue pertains to the AWS API
Projects
None yet
Development

No branches or pull requests

2 participants